[IntelMQ-dev] Small unpatching issue during build of intelmq v3.3.0

[Mika Silander]

-- 
Hi Sebastian, all,

 Thanks for your reply. I spent a good while digging through my Ubuntu's python3 packages and it seems some of the system python's packages were corrupt for God knows what reason (well, probably because of me). Fixing the mess was a pain but I can now confirm that, quilt unpatching succeeds as well as the "dpkg-buildpackage -us -uc -b -d" so the build runs as expected.

Br, Mika

----- Original Message -----
From: "Sebix" <sebix at sebix.at>
To: "mika silander" <mika.silander at csc.fi>, "intelmq-dev" <intelmq-dev at lists.cert.at>
Sent: Thursday, 4 April, 2024 12:12:02
Subject: Re: [IntelMQ-dev] Small unpatching issue during build of intelmq v3.3.0

Hi Mika,

On 4/4/24 10:33, Mika Silander via IntelMQ-dev wrote:

> Gave a try on intelmq v3.3.0 (cloned from github and on the develop branch) today and
> got this when running "dpkg-buildpackage -us -uc -b -d" on a Ubuntu 22.04 LTS:
>
> dpkg-buildpackage: warning:     debian/changelog(l5): ignoring invalid week day 'Fr'
> [...]
> LINE:  -- Aaron Kaplan <aaron at lo-res.org>  Fr, 01 Mar 2024 14:19:00 +0100
Side note: This warning will be fixed with
https://github.com/certtools/intelmq/pull/2490
> Patch fix-intelmq-paths.patch does not remove cleanly (refresh it or enforce with -f)
> dh_quilt_unpatch: error: quilt --quiltrc /dev/null pop -a || test $? = 2 returned exit code 1
> make: *** [debian/rules:20: clean] Error 1
> dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit status 2
>
>   What buttons, levers, cranks and the like should be turned to get passed the patching
> issue? I'd prefer not to have to enforce the thing as suggested.

I don't have a solution, just a few observations and thoughts:

The patch applies in our package builds on Ubuntu 22.04
(see
https://build.opensuse.org/build/home:sebix:intelmq/xUbuntu_22.04/x86_64/intelmq/_log)
and in the GitHub CI tests using buildah
(https://github.com/certtools/intelmq/actions/runs/8551898452/job/23431874437?pr=2490)
The latter uses dpkg-buildpackage -us -uc -b (without -d).
But -d, --no-check-builddeps shouldn't make a difference for the patching.
Neither the patch, nor the affected file were changed in the release
(last changes of both were in 2021).

best regards
Sebastian

-- 
Institute for Common Good Technology
gemeinnütziger Kulturverein - nonprofit cultural society
https://commongoodtechnology.org/
ZVR 1510673578