Hi Devs
I think Dustin's idea of having a list of the maintainers with write access would be very useful. Especially for someone who is new to the project it is good to know who will be able to merge the pull request. Currently, you kind of have to guess by looking at previous commits/issues.
I think keeping pull requests, regardless of whether more people will receive write access to the repository, is a good idea. PRs are a great way to do code review and get feedback from other contributors before merging a new feature. Just because you have write access to the repository does not mean that you can no longer make PRs.
As to having more maintainers it depends on the workload of the core maintainers. It would definitely be useful to have more than one person in case that person is on holidays or otherwise unavailable. Currently there are 13 open PRs and as far as I can tell there are a couple that can be merged and that I have been waiting for. However, not knowing who even has the rights to merge them makes it hard to know why they have not yet been merged.
If you/we trust the people enough to follow the community guidelines, then I think Dustin's suggestions are a good idea and might help speed up some of the processes (GitHub tells me that v1.0 Stable Release is already 2 months past due :)).
Cheers, Sybil
On 05/01/17 13:22, L. Aaron Kaplan wrote:
On 05 Jan 2017, at 11:51, Dustin Demuth dustin.demuth@intevation.de wrote:
Hi Dev's
I'm wondering how and if we want to organise write access to the main repository.
I definitely prefer the current model *for all of us* to send PRs and the core maintainers (mostly Sebix) has to go over the PRs and do some QA before merging them in.
It's really a matter of cleanliness and quality assurance.
That's what I want to ensure by this process.
Thanks, a.
-- // CERT Austria // L. Aaron Kaplan kaplan@cert.at // T: +43 1 505 64 16 78 // http://www.cert.at // Eine Initiative der nic.at GmbH // http://www.nic.at/ - Firmenbuchnummer 172568b, LG Salzburg
Intelmq-dev mailing list Intelmq-dev@lists.cert.at http://lists.cert.at/cgi-bin/mailman/listinfo/intelmq-dev