Hi IntelMQ-Devs,
when writing tests what is your development suggestion for writing similiar tests?
My problem:
intelmq/lib/test.py test_bot_name() checks that "Test class name must be Test{botclassname}."
But sometimes it would make sense to have a second test class within one test file. For example in intelmq/tests/bots/experts/modify/test_expert.py I am reusing some of the data of this tile. On this occasion I have used a different class name and explicitely disabled the test_bot_name().
You can reach the code via this search: https://github.com/certtools/intelmq/search?utf8=%E2%9C%93&q=test_bot_na...
I can see some merit checking for a consistent naming. However making it easier to write more tests is also a good aim and it looks like a good pattern to write more than one test class within one file.
What is your idea of solving this in the future?
(I meanwhile add another test using the same trick.)
Best Regards, Bernhard