<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body ><div style='font-size:10pt;font-family:Verdana,Arial,Helvetica,sans-serif;color:Default;'><div>Hi,<br></div><div><br></div><div>Because of dependency and clarity, i thing rsync collector is better option too. <br></div><div><br></div><div>There is no reason for implementation file deletion in rsync-collector. Condition of fast rsync is existing similar file.<br></div><div><br></div><div>Rsync copy only differences, so updating is really fast. But rsync-collector send to parser whole file.<br></div><div><br></div><div>Best regards <br></div><div>Ondřej Schindler<br></div><div> <br></div><div><br></div><div class="zmail_extra"><div id="Zm-_Id_-Sgn1"><div><br></div><div>---- On Mon, 06 Aug 2018 17:35:28 +0200 <b>Sebastian Wagner <wagner@cert.at></b> wrote ----<br></div></div><div><br></div><blockquote style="border-left: 1px solid #cccccc; padding-left: 6px; margin:0 0 0 5px"><div><p>Hi,<br></p><p>Does that the addition add support for `rsync://` filenames? Does it also implement file deletion (which is a feature of the file collector)? While I think that this could be quite easy, it may add another dependency to the file collector. If rsync-specific parameters emerge or rsync-specific features are added, I'd vote for a separate collector for clarity.<br></p><p>As I user I might expect that the collector only collects the differences to the previous fetch of the file? As that might be harder to implement, I think that a basic rsync-path support can be added to the file collector. But depends on how much features you actually want to implement.<br></p><p>Sebastian<br></p><div><br></div><div class="x_-1775507356moz-cite-prefix">On 2018-08-02 18:50, Ondřej Schindler wrote:<br></div><div><br></div><div><br></div><pre class="x_-1775507356moz-signature">--
// Sebastian Wagner <a target="_blank" href="mailto:wagner@cert.at" class="x_-1775507356moz-txt-link-rfc2396E"><wagner@cert.at></a> - T: +43 1 5056416 7201
// CERT Austria - <a target="_blank" href="https://www.cert.at/" class="x_-1775507356moz-txt-link-freetext">https://www.cert.at/</a>
// Eine Initiative der nic.at GmbH - <a target="_blank" href="https://www.nic.at/" class="x_-1775507356moz-txt-link-freetext">https://www.nic.at/</a>
// Firmenbuchnummer 172568b, LG Salzburg<br></pre></div><blockquote><div style="font-size: 10pt; font-family: Verdana, Arial, Helvetica, sans-serif; color: rgb(0, 0, 0)"><div>Hi,<br></div><div><br></div><div>i write these email, because i have to simply question, please. I want to add rsync collector to intelmq. Should i modify file collector (it would be max 5 lines of code) or should i create new collector?<br></div><div><br></div><div>Best regards<br></div><div>Ondřej Schindler<br></div><div><br></div></div><div><br></div><div><br></div><div><br></div><pre>_______________________________________________
Intelmq-dev mailing list
<a target="_blank" href="mailto:Intelmq-dev@lists.cert.at" class="x_-1775507356moz-txt-link-abbreviated">Intelmq-dev@lists.cert.at</a>
<a target="_blank" href="https://lists.cert.at/cgi-bin/mailman/listinfo/intelmq-dev" class="x_-1775507356moz-txt-link-freetext">https://lists.cert.at/cgi-bin/mailman/listinfo/intelmq-dev</a>
<br></pre></blockquote></blockquote></div><div><br></div></div><br></body></html>