<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>Does that the addition add support for `rsync://` filenames? Does
it also implement file deletion (which is a feature of the file
collector)? While I think that this could be quite easy, it may
add another dependency to the file collector. If rsync-specific
parameters emerge or rsync-specific features are added, I'd vote
for a separate collector for clarity.</p>
<p>As I user I might expect that the collector only collects the
differences to the previous fetch of the file? As that might be
harder to implement, I think that a basic rsync-path support can
be added to the file collector. But depends on how much features
you actually want to implement.</p>
<p>Sebastian<br>
</p>
<br>
<div class="moz-cite-prefix">On 2018-08-02 18:50, Ondřej Schindler
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:164fb8cb432.10de0fb3451082.3748728057613847856@whalebone.io">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div
style="font-size:10pt;font-family:Verdana,Arial,Helvetica,sans-serif;color:#000000;">
<div>Hi,<br>
</div>
<div><br>
</div>
<div>i write these email, because i have to simply question,
please. I want to add rsync collector to intelmq. Should i
modify file collector (it would be max 5 lines of code) or
should i create new collector?<br>
</div>
<div><br>
</div>
<div>Best regards<br>
</div>
<div>Ondřej Schindler<br>
</div>
<div><br>
</div>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Intelmq-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Intelmq-dev@lists.cert.at">Intelmq-dev@lists.cert.at</a>
<a class="moz-txt-link-freetext" href="https://lists.cert.at/cgi-bin/mailman/listinfo/intelmq-dev">https://lists.cert.at/cgi-bin/mailman/listinfo/intelmq-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
// Sebastian Wagner <a class="moz-txt-link-rfc2396E" href="mailto:wagner@cert.at"><wagner@cert.at></a> - T: +43 1 5056416 7201
// CERT Austria - <a class="moz-txt-link-freetext" href="https://www.cert.at/">https://www.cert.at/</a>
// Eine Initiative der nic.at GmbH - <a class="moz-txt-link-freetext" href="https://www.nic.at/">https://www.nic.at/</a>
// Firmenbuchnummer 172568b, LG Salzburg</pre>
</body>
</html>