<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br>On 17.01.2014, at 20:08, L. Aaron Kaplan <<a href="mailto:kaplan@cert.at">kaplan@cert.at</a>> wrote:<br><br><blockquote type="cite"><br>On Jan 17, 2014, at 6:44 PM, Aaron Zauner <<a href="mailto:azet@azet.org">azet@azet.org</a>> wrote:<br><br><blockquote type="cite"><br><br>L. Aaron Kaplan wrote:<br><blockquote type="cite">Anything else? If you want something on the agenda, please tell me or reply to this mail.<br></blockquote>Merging sebix's pull request :)<br><br></blockquote><br>Yes!! But we both said we'd finally do that this weekend, right :)<br><br>It's sort of important to get this in before we merge in other PRs.<br></blockquote><br><div>I have looked at it.</div><div>I have no comments content wise but regarding the listings-handling.</div><div>sebix has (and I had tried myself) tried to avoid the perl preprocessing.</div><div>While he got further than me, I would be reluctant to his approach for a few reasons.</div><div><br></div><div>1. The method requires a manual framing, as the manually inserted cipherstring </div><div> messes with listings.sty’s box-size calculation. On its own, this is not as </div><div> big a problem, but it has an ugly side effect (see first attachment, frame.png)</div><div><br></div><div>2. The line-broken cipher sting copies as</div><div>-->8---</div><div>SSLCipherSuite 'EDH+CAMELLIA:EDH+aRSA:EECDH+aRSA+AESGCM:EECDH+aRSA+SHA384:EECDH+aRS<br> A+SHA256:EECDH:+CAMELLIA256:+AES256:+CAMELLIA128:+AES128:+SSLv3:!aNULL:!eNULL:!LO<br> W:!3DES:!MD5:!EXP:!PSK:!DSS:!RC4:!SEED</div><div>--8<---</div><div> Which is a bit problematic, intended and automatic line breaks are indistinguishable.</div><div> You can define explicit eol-markers, but they end up in the copy-paste text.</div><div> (For example, the popular hooked arrow would spill in the copied cipher string)</div><div> </div><div> I would recommend an easily distinguishable end-of-line + beginning-of-line marker</div><div> (see 2nd attachment, redbackslash.png), which would copy as</div><div>-->8---<br>SSLCipherSuite 'EDH+CAMELLIA:EDH+aRSA:EECDH+aRSA+AESGCM:EECDH+aRSA\ \+SHA384:EECDH+aRSA+SHA256:EECDH:+CAMELLIA256:+AES256:+CAMELLIA128\ \:+AES128:+SSLv3:!aNULL:!eNULL:!LOW:!3DES:!MD5:!EXP:!PSK:!DSS:!RC4:!SEED:!\ \ECDSA:CAMELLIA256-SHA:AES256-SHA:CAMELLIA128-SHA:AES128-SHA'<br>--8<---</div><div> Note that</div><div> * the entire line is on one line,</div><div> * the explicit line-start and line-end markers are unambiguous and</div><div> * can be easily search-replaced (eg s/\\\ <a href="smb:////g">\\//g</a>)</div><div><br></div><div><br></div><div>I am not opposed to the change but I would nevertheless prepare another pr that</div><div>* makes this red-backslash thing</div><div>* explains it in the intro section</div><div>* Removes all listings from the .tex files and includes them manually (eg, as apache.conf)</div><div> * side effect: people browsing the github page can directly look at</div><div> the config files.</div><div><br></div><div>* If applicable, do the automatic generation/replacement in the config files (not the .tex files)</div><div> * probably with sed, as I don’t really know perl, and it can be done in the makefile directly.</div><div> * side effect 2: the people could download the correct config files directly, no need for copy and paste</div><div> (but we would have to version them :( )</div><div><br></div><div>Sorry for the long text, i had no time writing a shorter one</div><div><br></div><div>Best</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>-Tobias</div><div><br></div><div><br></div><div><br></div><div><img apple-inline="yes" id="90B7DCCA-F905-48A1-AD03-5739B12E605D" height="108" width="451" apple-width="yes" apple-height="yes" src="cid:3EA3022A-3BA5-4742-B1E3-2C0E21023468@fritz.box"><img apple-inline="yes" id="76C1A1D1-DBEE-434B-AB42-1561E1B4793D" height="100" width="851" apple-width="yes" apple-height="yes" src="cid:5CF20BBA-059A-45E2-9281-B51A1B3BF990@fritz.box"></div></body></html>